add system user #5087
add system user #5087
Conversation
This user is logged as the acting user for jobs and other processes that run without being attributed to a specific user (e.g. creation of the default admin set).
app/models/concerns/hyrax/user.rb
Outdated
| @@ -145,6 +145,15 @@ def all_user_activity(since = DateTime.current.to_i - 1.day) | |||
| end | |||
|
|
|||
| module ClassMethods | |||
| # Override this method if you aren't using email/password | |||
There was a problem hiding this comment.
what does this mean? will this addition be breaking for users who "aren't using email/password"?
There was a problem hiding this comment.
I copied this comment from audit_user. The same comment exists for batch_user. I assumed it would apply for system_user as well.
There was a problem hiding this comment.
I do not know if it would be a breaking change. I suspect not as there is a default configuration for the system_user_key. But I'd have to see what an alternative implementation looks like.
There was a problem hiding this comment.
git blame says the comment for audit was added 9 years ago
|
looks good. i have a question about the comment. i'm wondering whether it's accurate/helpful. i get that it's copied from below, but for my part, i don't understand what it means. i wonder whether we expect application implementer to see it, and how they would know what override is needed if they did. |
The override comment is not clear and is being removed.
This user is logged as the acting user for jobs and other processes that run without being attributed to a specific user (e.g. creation of the default admin set).
Used by PR #5083, update AdminSetCreateService to create valkyrie resources, when creating the default admin set.
Replaces PR #5077 which looked at adding a fake NullUser. It was decided that a real user was expected.
@samvera/hyrax-code-reviewers