add feature tests for creating admin sets and collections #5093
Conversation
| add_breadcrumb t(:'hyrax.admin.sidebar.admin_sets'), hyrax.admin_admin_sets_path | ||
| @admin_sets = Hyrax::AdminSetService.new(self).search_results(:edit) | ||
| # admin sets are listed with collections | ||
| redirect_to hyrax.my_collections_url |
There was a problem hiding this comment.
This is the behavior change to redirect :index to /dashboard/my/collections
| @@ -74,7 +74,21 @@ def access_grants_attributes | |||
| ].tap do |attribute_list| | |||
| # Grant manage access to the creating_user if it exists. Should exist for all but default Admin Set | |||
| attribute_list << { agent_type: 'user', agent_id: creating_user.user_key, access: Hyrax::PermissionTemplateAccess::MANAGE } if creating_user | |||
| end + managers_of_admin_set | |||
There was a problem hiding this comment.
This is the behavior change to copy the managers from the admin set collection type to the admin set when it is created.
| @@ -84,7 +98,8 @@ def admin_group_name | |||
| ## | |||
| # @return [PermissionTemplate] | |||
| def create_permission_template | |||
| permission_template = PermissionTemplate.create!(source_id: admin_set.id, access_grants_attributes: access_grants_attributes) | |||
| permission_template = PermissionTemplate.create!(source_id: admin_set.id, | |||
| access_grants_attributes: access_grants_attributes.uniq) | |||
There was a problem hiding this comment.
There will be dups in the grants if one of the managers from the admin set collection type is the creating user. Adding .uniq to only add a user once.
| @@ -12,7 +12,7 @@ | |||
| <% @collection_type_list_presenter.each do |row_presenter| %> | |||
| <div class="radio radio-button-list"> | |||
| <label> | |||
| <input type="radio" name="collection_type" | |||
| <input type="radio" name="collection_type" value="<%= row_presenter.title.gsub(/\s+/, '') %>" | |||
There was a problem hiding this comment.
Adding the title as the value is to support feature tests which need a way to select a radio button.
| end | ||
|
|
||
| class CollectionTypeFactoryHelper | ||
| def self.process_access(collection_type, evaluator) # rubocop:disable Metrics/MethodLength |
There was a problem hiding this comment.
Moved access grants to the helper class to allow the code to be shared among factories.
elrayle
force-pushed
the
admin_set_perm_tests
branch
2 times, most recently
from
654e814
to
2effa87
Compare
| @@ -4,9 +4,7 @@ class Admin::AdminSetsController < ApplicationController | |||
| include Hyrax::CollectionsControllerBehavior | |||
|
|
|||
| before_action :authenticate_user! | |||
| before_action :ensure_manager!, except: [:show] | |||
There was a problem hiding this comment.
Checks for manager and viewer are covered by cancan authentication. Feature tests and controller tests behave correctly for each user type. Interactions with the test app in the browser also confirm that the controller limits access as expected.
elrayle
force-pushed
the
admin_set_perm_tests
branch
from
2effa87
to
a5bb335
Compare
Extended testing for admin sets: * add feature tests for creating admin sets and collections Changes in the controller test… * specify more precisely failures redirects and flash messages * test abilities of admin set collection type managers and creators to manipulate admin sets through the controller. This extended testing confirms that abilities are sufficient to control access to admin sets. Unexpected behaviors that are fixed in this PR: * Admin sets were not copying over manager permissions. * path `/admin/admin_sets` did not forward to `/dashboard/my/collections` The behavioral changes these fixes impart were discussed in the tech call and approved by Hyrax PO.
elrayle
force-pushed
the
admin_set_perm_tests
branch
from
a5bb335
to
dbaec48
Compare
There was a problem hiding this comment.
These changes help adjust some application behaviors so that viewing the list of admin sets and collections in the dashboard can only be done in the UI through the single collections view that includes admin sets with collections. These changes also make sure that any manager role assigned to an admin set collection type is given edit permissions on any admin set created with that admin set collection type. As Hyrax PO, I approve these changes.
Extended testing for admin sets:
Changes in the controller test…
This extended testing confirms that abilities are sufficient to control access to admin sets.
Unexpected behaviors that are fixed in this PR:
/admin/admin_setsdid not forward to/dashboard/my/collectionsThe behavioral changes these fixes impart were discussed in the tech call and approved by Hyrax PO.
@samvera/hyrax-code-reviewers