refactor AdminSetCreateService specs #5213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these tests need some love. i think the service probably does too (it's calling a deprecated method on itself from a current public method!), but tests first.
|
I have in the works a refactor of AdminSetCreateServices which will include changes to the specs. I'll try to prioritize getting the PR for that ready. This PR may not be necessary. |
thanks! i'll mark this draft for the time being and we can consider it dependent on what happens with the other branch. i had originally worked on this as a precursor to working on the implementation, so i'm glad we didn't end up with too much overlapping effort here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these tests need some love. i think the service probably does too (it's calling
a deprecated method on itself from a current public method!), but tests first.
@samvera/hyrax-code-reviewers