-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support previous yaml config structure for Analytics #5315
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or folks to transition their applications to the new format
cjcolvar
previously approved these changes
Jan 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. My comments are small cleanup suggestions and shouldn't block merging since getting this change in is important.
Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
@cjcolvar completely agree with those suggestions. thank you! |
cjcolvar
previously approved these changes
Jan 3, 2022
dunn
approved these changes
Jan 6, 2022
…samvera/hyrax into support_previous_analytics_yaml
cjcolvar
approved these changes
Jan 7, 2022
yay! thank you to all who helped me get this through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing time for folks to transition their applications to the new format. This is meant to allow analytics to be released as a minor instead of a major release.
@samvera/hyrax-code-reviewers