Geonames labels #5493
Merged
Geonames labels #5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpierce
force-pushed
the
geonames_labels
branch
from
95a4156
to
1f77e22
Compare
|
I used this branch to set a location and got an error while saving the new work...
|
|
Looks like it is happening when trying to generate the cache key...
If you drop the |
elrayle
requested changes
Mar 14, 2022
|
PR #5533 fixes the issue where prevents canonicalize from returning the string version of the URI. This should unblock this PR. |
elrayle
force-pushed
the
geonames_labels
branch
from
1f77e22
to
35dfbe8
Compare
elrayle
previously approved these changes
Mar 15, 2022
dlpierce
force-pushed
the
geonames_labels
branch
from
35dfbe8
to
b9ab5a7
Compare
|
Removed configuration changes as they were unneeded. |
elrayle
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1065, #3269
Retrieves, indexes and displays the full location label
Previously when indexing the Based Near/Location field on works, only the city name was available as it was all that is available in the rdf data that was retrieved. This PR add a service that retrieves a full label from another Geonames endpoint via questioning authority, caching the results locally. That service is then used when creating the solr doc and rendering the edit form.
Geonames wants a username to use this service. This is defined in
config/initializers/hyrax.rbasconfig.geonames_username = Qa::Authorities::Geonames.username = '{username}'to set the user in Qa at the same time.Changes proposed in this pull request:
Guidance for testing, such as acceptance criteria or new user interface behaviors:
@samvera/hyrax-code-reviewers