Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deprecation notices for transactions that are no longer supported #5518

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

elrayle
Copy link
Contributor

@elrayle elrayle commented Mar 10, 2022

This does a bit of cleanup as well. There should not be any impact on the function of code.

  • rename update_work to work_update - All resources follow the pattern resourcetype_create, resourcetype_destroy, resourcetype_update. The other work transactions followed this pattern already (e.g. work_create and work_destroy).
  • moved requires for deprecated transactions and steps to a separate location to make them easier to remove later
  • add more prominent DO NOT USE notice to deprecated legacy AF work transactions - This has been a source of confusion for several developers
  • added deprecation notices to steps that are no longer supported

@samvera/hyrax-code-reviewers

@dlpierce dlpierce merged commit 61f353a into main Mar 10, 2022
@dlpierce dlpierce deleted the deprecate_old_transactions branch March 10, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants