Gen collection resource #5519
Closed
Gen collection resource #5519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrayle
force-pushed
the
gen_collection_resource
branch
2 times, most recently
from
f1823fd
to
2efeb7c
Compare
Generates: 1. Creates a collection model and spec. 2. Creates a collection form and spec. 3. Creates a collection indexer and spec. 4. Creates a collection metadata config. 5. Sets this to be the collection class. create a collection resource in test app, but don’t make it ‘the’ collection This provides a PcdmCollection for use in testing. It does not make it ‘the’ collection class for the test app. That remains `::Collection` until we are ready for a full switch to Valkyrie.
The collection resource generator will include basic metadata in the generated collection class.
elrayle
force-pushed
the
gen_collection_resource
branch
from
2efeb7c
to
0bafa52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Hyrax::PcdmCollectionCollection Resource Generator
Generates:
The generated collection resource classes include
basic_metadata.Move basic metadata
The generated collection resource class includes
basic_metadata. For that reason, the inclusion ofbasic_metadatawas removed fromHyrax::PcdmCollectionand its indexer._NOTE: This follows the pattern used for works where
Hyrax::Workincludescore_metadata, but notbasic_metadata, as it is included in generated work classes.Add CollectionResource in test app
The test generator was updated to create a collection resource class named "CollectionResource". The config that is generated to set this as 'the' collection class is commented out in
/config/initializers/hyrax.rbby the test generator.For now, this allows the ActiveFedora
::Collectionclass to continue to be 'the' collection class.NOTE: At this time, Hyrax supports a single class that is 'the' collection class. It is configured in
config/initializers/hyrax.rbby settingconfig.collection_model =.Potential Future Work
This pattern allows for future work that would update Hyrax to allow multiple collection resource classes each with their own metadata.
Related Work
This PR replaces the proposed work in PR #5157 that added a separate
collection_basic_metadatafile.@samvera/hyrax-code-reviewers