Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured Works MIA After Reindex #5598

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Conversation

orangewolf
Copy link
Member

Stop removing featured records if the item is missing from the index. If an app is being reindexed OR solr is having a bad day, we shouldn't destroy database records, just skip them.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Create a work
  • Feature that work
  • Clear or drop your solr index
  • Load the home page
  • Reindex
  • Previously the work would no longer be featured, with this code change the featuring comes back

@samvera/hyrax-code-reviewers

Stop removing featured records if the item is missing from the index. If an app is being reindexed OR solr is having a bad day, we shouldn't destroy database records, just skip them.
@no-reply
Copy link
Contributor

!!

thanks for this. looks like a very long lived issue, but i can't see any good reason why listing featured works should ever destroy them.

@no-reply no-reply merged commit b852ade into main Apr 11, 2022
@no-reply no-reply deleted the delete_not_lest_ye_be_deleted branch April 11, 2022 23:43
@dlpierce dlpierce added the notes-bugfix Release Notes: Fixed a bug label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants