Fix translations in german locale file #5601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some literal translations do not fit the context
cjcolvar
requested changes
Apr 13, 2022
|
@jzimpel I don't see CLAs on file for you. Unfortunately I believe the current Samvera policy requires CLAs even for this kind of contribution. Fortunately though, the Samvera board is considering removing this requirement at its meeting later this month. If you don't want to wait until then to get this PR merged then you'll have to submit a cCLA and iCLA. Sorry! |
|
@cjcolvar Ok, I'll have a look at it. Thanks so far! |
cjcolvar
approved these changes
Apr 23, 2022
|
The CLA requirement has been dropped so nothing is blocking this now. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a native german speaker I found some literal translations in the german locale file that do not fit the context.
It' s not a complete review of the locale, just a few that caught my attention when updating hyrax to v3.4.1
@samvera/hyrax-code-reviewers