valkyrie: persist derivatives using storage adapter #5603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunn
force-pushed
the
valkyrie-derivatives-storage
branch
from
01bf7cf
to
607a066
Compare
tpendragon
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the existing
Hyrax::PersistDerivativesservice expects to be passed an AF object, resulting in an error when we try to create derivatives for Valkyrie objects. this new service handles theStringIOpassed from the Valkyrie derivative creation job, and also uses the application's defined storage adapter for persisting the derivatives produced.@samvera/hyrax-code-reviewers