use the ActiveModel::Name#human instead of #to_s for human names
#5625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
model-name-human
branch
from
741ad30
to
756075d
Compare
dunn
previously approved these changes
May 12, 2022
no-reply
force-pushed
the
model-name-human
branch
from
756075d
to
461de96
Compare
when grouping relationship presenters for display in the show view, calling `#to_s` results in a Ruby style model name. we want to display the human name, which `ActiveModel` supports via `#human`. the view also calls `String#humanize` which should be a no-op in most cases after this, but still seems appropriate. fixes #5587.
|
@dunn oops, i guess i misspelled "Collection", because of my strong attention to detail. fixed now and rebuilding. |
1 similar comment
|
@dunn oops, i guess i misspelled "Collection", because of my strong attention to detail. fixed now and rebuilding. |
dunn
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when grouping relationship presenters for display in the show view, calling
#to_sresults in a Ruby style model name. we want to display the human name,which
ActiveModelsupports via#human.the view also calls
String#humanizewhich should be a no-op in most casesafter this, but still seems appropriate.
fixes #5587.
@samvera/hyrax-code-reviewers