Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminates duplicate Collection relation. #5669

Merged
merged 5 commits into from
Jun 15, 2022
Merged

Eliminates duplicate Collection relation. #5669

merged 5 commits into from
Jun 15, 2022

Conversation

bwatson78
Copy link
Contributor

Fixes #5668

Changes proposed in this pull request:

  • app/presenters/hyrax/work_show_presenter.rb: adds humanized string of "Collection" to the presenter types, since #grouped_presenters humanizes the keys to exclude.
  • spec/features/work_show_spec.rb: adds an expectation that there will be only one link.

@samvera/hyrax-code-reviewers

@bwatson78 bwatson78 force-pushed the eliminate_duplicate_collection_relation branch from 0121673 to c650aca Compare June 14, 2022 18:55
@bwatson78
Copy link
Contributor Author

@cjcolvar Ready for your re-review.

cjcolvar
cjcolvar approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cjcolvar cjcolvar merged commit 2a6fb47 into main Jun 15, 2022
@cjcolvar cjcolvar deleted the eliminate_duplicate_collection_relation branch June 15, 2022 20:32
@dlpierce dlpierce added the notes-bugfix Release Notes: Fixed a bug label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collection relationships display twice on View Work page [Rails 6 testing]
3 participants
@bwatson78 @cjcolvar @dlpierce