always pull repo file if filepath param is missing #5694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
reviewed
Jun 21, 2022
conorom
force-pushed
the
5676-versions-same-filename-working-directory
branch
from
f804204
to
8f1c9e0
Compare
conorom
force-pushed
the
5676-versions-same-filename-working-directory
branch
from
8f1c9e0
to
73fa1ca
Compare
no-reply
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5676
Remove Hyrax::WorkingDirectory.find_or_retrieve() as it cannot handle FileSet file versions using the same filename.
This module is marked as deprecated anyway, and its removal a suggested (future) TODO on this PR.
@samvera/hyrax-code-reviewers