Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated use_valkyrie argument from InheritPermissionsJob #5738

Merged
merged 1 commit into from
Jun 28, 2022
Merged

remove deprecated use_valkyrie argument from InheritPermissionsJob #5738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/hyrax/batch_edits_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def update_document(obj)
obj.attributes = work_params(admin_set_id: obj.admin_set_id).except(*visibility_params)
obj.date_modified = Time.current.ctime

InheritPermissionsJob.perform_now(obj, use_valkyrie: false)
InheritPermissionsJob.perform_now(obj)
VisibilityCopyJob.perform_now(obj)

obj.save
Expand Down
6 changes: 1 addition & 5 deletions app/jobs/inherit_permissions_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,7 @@ class InheritPermissionsJob < Hyrax::ApplicationJob
# Perform the copy from the work to the contained filesets
#
# @param work containing access level and filesets
# @param use_valkyrie [Boolean] whether to use valkyrie support (deprecated)
def perform(work, use_valkyrie: :DEFAULT)
Deprecation.warn("use_valkyrie argument is deprecated, behavior depends on deserialized resource") unless
use_valkyrie == :DEFAULT

def perform(work)
case work
when ActiveFedora::Base
af_perform(work)
Expand Down