Create .koppie (.dassie without Fedora) #5830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpierce
commented
Aug 31, 2022
| unless defined? Role | ||
| unless ::User.reflect_on_association(:roles) |
There was a problem hiding this comment.
Role seemed to not be loaded while running rake db:seed, so this instead checks if the user model has a roles association which add_user also depends on existing.
jeremyf
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of Koppie is to provide a way for developers to work on valkyrie support in hyrax, without the presence of Fedora, in the same way .dassie is currently used.
It was created by copying the current nurax-pg application into the .koppie directory and then removing the parts unneeded for running only in the docker-compose environment, such as capistrano deployment. It has its own compose file
docker-compose-koppie.ymlwhich can be used like so:docker-compose -f docker-compose-koppie.yml upOne additional fix was made to the recently added seed data system to allow the admin role to be assigned.
As noted in the README, koppies are isolated granite outcrops in Southern Africa that are a favored habitat for hyraxes.
@samvera/hyrax-code-reviewers