Ensuring Hyrax::UserStatImporter returns false on exception #5874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, in the retriable block, if we hit an exception, we'd return `true` and upstream we'd raise an exception. In the below code, the `extract_stats_for` is returning true, because calls to `Rails.logger.info` return true. ```ruby view_stats = extract_stats_for(object: file, from: FileViewStat, start_date: start_date, user: user) stats = tally_results(view_stats, :views, stats) if view_stats.present? ``` This resulted in attempting to call `.each` on the `view_stats`; which was true. This builds on a [reported issue in Slack][1]. Closes #5873 [1]:https://samvera.slack.com/archives/C0F9JQJDQ/p1663608069939129
cjcolvar
approved these changes
Sep 20, 2022
dlpierce
deleted the
jeremyf-ensuring-stat-importer-handles-logged-exceptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, in the retriable block, if we hit an exception, we'd return
trueand upstream we'd raise an exception.In the below code, the
extract_stats_foris returning true, because calls toRails.logger.inforeturn true.This resulted in attempting to call
.eachon theview_stats; which was true.This builds on a reported issue in Slack.
Closes #5873
@samvera/hyrax-code-reviewers
This can be back-ported to 3.4.x.