Remove unneeded variables in FileSet permission_form #5889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These definitions date back to commit eb9d5cb in May 2015, before the adoption of `hyrax/base/form_permission` for actually rendering this form out (by a different name, in commit f77f4d4, Dec 2015). They don’t appear to do anything now and are incompatible with the newer Hyrax permission model. The need for `depositor` was removed somewhat later, in commit 70ff2ee (Feb 2021).
jeremyf
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These definitions date back to commit eb9d5cb in May 2015, before the adoption of
hyrax/base/form_permissionfor actually rendering this form out (by a different name, in commit f77f4d4, Dec 2015). They don’t appear to do anything now and are incompatible with the newer Hyrax permission model.The need for
depositorwas removed somewhat later, in commit 70ff2ee (Feb 2021).