remove dependency on dry-transaction #5901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we don't really use any of the `Dry::Transaction` code. the dependency should have been removed when the legacy transactions got removed for 4.x.
no-reply
pushed a commit
that referenced
this pull request
Oct 19, 2022
backport/alternative to #5901.
During the `hyrax:install` generator, this formerly threw a `RuntimeError`, but recent changes in Blacklight have resulting in it now throwing a `NoMethodError`. We want to catch *all* errors getting the blacklight config during `hyrax:install` generation, so this commit changes it to just rescue `StandardError` instead.
marrus-sh
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we don't really use any of the
Dry::Transactioncode. the dependency should have been removed when the legacy transactions got removed for 4.x.@samvera/hyrax-code-reviewers