Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyrax-5933 - Review submission support paging #5999

Merged
merged 20 commits into from
Jun 30, 2023

Conversation

bbpennel
Copy link
Contributor

@bbpennel bbpennel commented Mar 31, 2023

Fixes #5933

Updates the Review Submission page to make it behave more like the my/works page, meaning:

  1. Each tab now makes a separate request for works, either Under Review or Published
  2. Searching, paging and updating page size now trigger new requests
  3. Paging of results is performed server-side

As a result, ActionableObjects now supports query and paging related parameters, which are also now supported in scope_entities_for_the_user.

Guidance for testing

  1. Create an admin set using the provided mediated deposit workflow (using dassie)
  2. Deposit 11 works into the mediate deposit workflow admin set
  3. Without the changes in this PR, only the first 10 should show, without the ability to show more. With this PR, it should be possible to page to the 11th item, or to use the page size dropdown to display all items.
  4. Next, navigate to one of the works and approve it
  5. In the "Review submissions" page, with this PR 10 under review works should show, and in the Published tab there should be 1 item.
  6. The search input should also work to filter by title.

@samvera/hyrax-code-reviewers

@bbpennel bbpennel marked this pull request as ready for review April 3, 2023 14:21
@bbpennel bbpennel changed the title WIP: Hyrax-5933 - Review submission support paging Hyrax-5933 - Review submission support paging Apr 3, 2023
@bbpennel
Copy link
Contributor Author

bbpennel commented Apr 3, 2023

I don't think the test failures are related to this PR, they are documented as being flaky
#5945
#5946

@bbpennel
Copy link
Contributor Author

bbpennel commented Apr 3, 2023

While back porting this to hyrax 3 and testing it with my local application, I am realizing that the result count doesn't take into account the keyword filtering, since that is taking place in solr after the sipity queries have completed. I'm trying to figure out if there's any way to support that behavior.

@bbpennel
Copy link
Contributor Author

bbpennel commented Apr 4, 2023

I ended up removing the option to search by title since I couldn't think of a reasonable way to make that work. I made it sort by submission date instead, since that was available in both psql and solr, and would at least make the ordering non-random.

orangewolf
orangewolf previously approved these changes May 24, 2023
@orangewolf
Copy link
Member

this is a great thing to see! the 'fake' js paginating on this and notifications causes lots of problems at scale =-)

@orangewolf orangewolf merged commit c7dad8b into samvera:main Jun 30, 2023
@orangewolf
Copy link
Member

I'm working on workflows approval for Valkyrie today. I'm glad to have this merged in before I start on that =-D

@dlpierce dlpierce added the notes-minor Release Notes: Non-breaking features label Aug 25, 2023
@bbpennel bbpennel deleted the hyrax-5933-rev-subs branch August 28, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-minor Release Notes: Non-breaking features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review submissions page does not show all works
6 participants