-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyrax-5933 - Review submission support paging #5999
Conversation
…Restructure the response for workflow requests to mirror that of a blacklight response. Add method for getting total number of entities in workflow
0ad6f6c
to
9e7a767
Compare
449bb49
to
a02c9d9
Compare
a02c9d9
to
ca46c2d
Compare
While back porting this to hyrax 3 and testing it with my local application, I am realizing that the result count doesn't take into account the keyword filtering, since that is taking place in solr after the sipity queries have completed. I'm trying to figure out if there's any way to support that behavior. |
… the initial query to get entity ids
…t some sense to the ordering
I ended up removing the option to search by title since I couldn't think of a reasonable way to make that work. I made it sort by submission date instead, since that was available in both psql and solr, and would at least make the ordering non-random. |
this is a great thing to see! the 'fake' js paginating on this and notifications causes lots of problems at scale =-) |
I'm working on workflows approval for Valkyrie today. I'm glad to have this merged in before I start on that =-D |
Fixes #5933
Updates the Review Submission page to make it behave more like the my/works page, meaning:
As a result, ActionableObjects now supports query and paging related parameters, which are also now supported in
scope_entities_for_the_user
.Guidance for testing
@samvera/hyrax-code-reviewers