Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5844-save-embargoes-again #6116

Closed
wants to merge 1 commit into from
Closed

Commits on Jul 24, 2023

  1. we are able to save embargoes again.

    Idk why we were not able to. the work that was done on #6098 was to be able to deactivate embargoes, and we were able to save them as well. however, when that pr got merged to main, I was no longer able to set an embargo at all in koppie.
    saving the embargo in app/models/hyrax/resource.rb#embargo= is something we committed at efffe9b, but we then removed it and opted to save the embargo in lib/hyrax/transactions/steps/save.rb#call. however, the `value` argument that gets passed to #embargo= does not have a valid id. just an empty string. so we do not ever set or find the embargo. this change does at least work.
    alishaevn committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    1938cb0 View commit details
    Browse the repository at this point in the history