-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6126 deactivated leases #6127
6126 deactivated leases #6127
Commits on Jul 14, 2023
-
decouple the deactivated lease work from the deactivated embargo work.
technically the lease work is not part of #5844, however, it will need to updated similarly to embargoes and I do not see a ticket for it. so the work is being done here wile the embargo work is fresh on our minds. co-authored-by: braydon <braydon.justice@1268456bcltd.ca>
Configuration menu - View commit details
-
Copy full SHA for 6cc1544 - Browse repository at this point
Copy the full SHA 6cc1544View commit details
Commits on Jul 17, 2023
-
move over a few more lease related changes from #6098.
co-authored-by: braydon <braydon.justice@1268456bcltd.ca>
Configuration menu - View commit details
-
Copy full SHA for 7b19cca - Browse repository at this point
Copy the full SHA 7b19ccaView commit details
Commits on Jul 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b8789d1 - Browse repository at this point
Copy the full SHA b8789d1View commit details
Commits on Jul 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 42d504b - Browse repository at this point
Copy the full SHA 42d504bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed8f13a - Browse repository at this point
Copy the full SHA ed8f13aView commit details -
make the lease code in the resource and save files follow the updated…
… embargo pattern
Configuration menu - View commit details
-
Copy full SHA for d26467d - Browse repository at this point
Copy the full SHA d26467dView commit details -
wip: update more of the lease code to look like the embargo code so t…
…hat we can create and deactivate them too.
Configuration menu - View commit details
-
Copy full SHA for 16cdbfa - Browse repository at this point
Copy the full SHA 16cdbfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8061f33 - Browse repository at this point
Copy the full SHA 8061f33View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf1b1eb - Browse repository at this point
Copy the full SHA bf1b1ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for d413323 - Browse repository at this point
Copy the full SHA d413323View commit details -
Configuration menu - View commit details
-
Copy full SHA for fac77c3 - Browse repository at this point
Copy the full SHA fac77c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0362456 - Browse repository at this point
Copy the full SHA 0362456View commit details
Commits on Jul 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c886e64 - Browse repository at this point
Copy the full SHA c886e64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c86b0f - Browse repository at this point
Copy the full SHA 0c86b0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f979dc - Browse repository at this point
Copy the full SHA 1f979dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b5b054 - Browse repository at this point
Copy the full SHA 4b5b054View commit details
Commits on Jul 31, 2023
-
only check for the embargo and lease, if they exist on the change_set…
… being passed to Hyrax::Transactions::Steps::Save#call
Configuration menu - View commit details
-
Copy full SHA for 6314351 - Browse repository at this point
Copy the full SHA 6314351View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33ebb3d - Browse repository at this point
Copy the full SHA 33ebb3dView commit details -
convert the embargo/lease DateTime to Date on the work/edit screen fo…
…r better ux and ui
Configuration menu - View commit details
-
Copy full SHA for 9975ac8 - Browse repository at this point
Copy the full SHA 9975ac8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3154b19 - Browse repository at this point
Copy the full SHA 3154b19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a59d45 - Browse repository at this point
Copy the full SHA 6a59d45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a8398f - Browse repository at this point
Copy the full SHA 5a8398fView commit details
Commits on Aug 1, 2023
-
disable validation on the Active Fedora object in Wings::Valkyrie::Pe…
…rsister#save because we have already done validation as a Valkyrie object. co-authored-by: rob <rob@scientist.com>
Configuration menu - View commit details
-
Copy full SHA for 9b64c54 - Browse repository at this point
Copy the full SHA 9b64c54View commit details -
allow for spec/wings/active_fedora_converter_spec.rb:37 to pass.
af_object.lease.class has the same name as resource.lease.class; however, each class has a different object_id. so a type mismatch happens. the code below coerces the one object into the other. TODO: fix this! co-authored-by: jeremy <jeremy.n.friesen@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 530750c - Browse repository at this point
Copy the full SHA 530750cView commit details -
skip spec/wings/active_fedora_converter_spec.rb:36 when using valkyri…
…e because valkyrie does not respond to `valid?`
Configuration menu - View commit details
-
Copy full SHA for cfc5d91 - Browse repository at this point
Copy the full SHA cfc5d91View commit details -
make sure that
af_object
responds tolease
before fetching it ins……ide Wings::ActiveFedoraConverter#apply_attributes_to_model
Configuration menu - View commit details
-
Copy full SHA for cef578a - Browse repository at this point
Copy the full SHA cef578aView commit details -
update spec/services/hyrax/admin_set_create_service_spec.rb:294to exp…
…ect "ActiveRecord::RecordNotFound" isntead of "RuntimeError". previously running `Hyrax.persister.save(resource: admin_set)` in Hyrax::AdminSetCreateService#create! would have failed. however, with the change in commit 9b64c54 we are no longer validating valkyrie turned active fedora objects. this means a failure happens in app/models/sipity/workflow.rb:55 since the admin set is invalid.
Configuration menu - View commit details
-
Copy full SHA for 10215f0 - Browse repository at this point
Copy the full SHA 10215f0View commit details -
we no longer need to set
embargo_history
andlease_history
to emp……ty arrays in Wings::ModelTransformer#append_embargo and Wings::ModelTransformer#append_lease. we are now setting the values to empty arrays in Hyrax::Forms::Embargo/Lease and Hyrax::Forms::WorkLeaseForm/WorkEmbargoForm
Configuration menu - View commit details
-
Copy full SHA for 6b76967 - Browse repository at this point
Copy the full SHA 6b76967View commit details -
Configuration menu - View commit details
-
Copy full SHA for 753d216 - Browse repository at this point
Copy the full SHA 753d216View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82bb390 - Browse repository at this point
Copy the full SHA 82bb390View commit details -
Configuration menu - View commit details
-
Copy full SHA for cee247a - Browse repository at this point
Copy the full SHA cee247aView commit details
Commits on Aug 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5fdc19f - Browse repository at this point
Copy the full SHA 5fdc19fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff52b95 - Browse repository at this point
Copy the full SHA ff52b95View commit details -
reindex the file set with the correct lease related properties when a…
… lease has been added to its parent work
Configuration menu - View commit details
-
Copy full SHA for d315ec2 - Browse repository at this point
Copy the full SHA d315ec2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ea729a - Browse repository at this point
Copy the full SHA 8ea729aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b3bd3cc - Browse repository at this point
Copy the full SHA b3bd3ccView commit details
Commits on Aug 3, 2023
-
also remove the
:id
attribute when coercing the resource lease into…… the af_object lease inside #apply_attributes_to_model.this avoids the "Attempting to recreate existing ldp_source" error in dozens of specs
Configuration menu - View commit details
-
Copy full SHA for ad4f247 - Browse repository at this point
Copy the full SHA ad4f247View commit details -
yet again...update #apply_attributes_to_model. make sure that the res…
…ource responds to the `lease` method before calling it
Configuration menu - View commit details
-
Copy full SHA for 5c4486d - Browse repository at this point
Copy the full SHA 5c4486dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef3f8e2 - Browse repository at this point
Copy the full SHA ef3f8e2View commit details -
update the active_fedora_converter_spec example that expected the con…
…verted item to have the same lease_id as the original resource
Configuration menu - View commit details
-
Copy full SHA for 6c071cb - Browse repository at this point
Copy the full SHA 6c071cbView commit details -
adjust Hyrax::WorksControllerBehavior#create_valkyrie_work error hand…
…ling so that generic_works_controller_json_spec.rb:58 passes. should be a green pipeline! co-authored-by: jeremy <jeremy.n.friesen@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3c503bf - Browse repository at this point
Copy the full SHA 3c503bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45f586b - Browse repository at this point
Copy the full SHA 45f586bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77f7ac0 - Browse repository at this point
Copy the full SHA 77f7ac0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 720b140 - Browse repository at this point
Copy the full SHA 720b140View commit details -
Configuration menu - View commit details
-
Copy full SHA for 796a1f6 - Browse repository at this point
Copy the full SHA 796a1f6View commit details -
conditionally validate Wings::Valkyrie::Persister#save.
by default we will not validate the converted af_object because validations should have been run on the Valkyrie created object. however, there are situations where we will have created an ActiveFedora object while `Hyrax.config.use_valkyrie?` is TRUE. (see: spec/controllers/hyrax/generic_works_controller_json_spec.rb:59) this change accounts for that use case.
Configuration menu - View commit details
-
Copy full SHA for 9896d7a - Browse repository at this point
Copy the full SHA 9896d7aView commit details -
also skip the Hyrax::Actors::CollectionsMembershipActor specs if Hyra…
…x.config.use_valkyrie is true
Configuration menu - View commit details
-
Copy full SHA for 04c9c2e - Browse repository at this point
Copy the full SHA 04c9c2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d54048 - Browse repository at this point
Copy the full SHA 9d54048View commit details
Commits on Aug 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a1ea69c - Browse repository at this point
Copy the full SHA a1ea69cView commit details -
able to add leases to newly added file sets too, not just preexisting…
… ones. accounting for a work with file set that did not have a lease, then added one. a work that was created with a file set and lease, plus a work that already had a lease and added a file set.
Configuration menu - View commit details
-
Copy full SHA for b2a9f23 - Browse repository at this point
Copy the full SHA b2a9f23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e28096 - Browse repository at this point
Copy the full SHA 3e28096View commit details -
restore spec/services/hyrax/admin_set_create_service_spec.rb:294 to i…
…ts previous expectations by passing `perform_af_validation: true` in `Hyrax::AdminSetCreateService#create!`
Configuration menu - View commit details
-
Copy full SHA for 8970a44 - Browse repository at this point
Copy the full SHA 8970a44View commit details -
I am not sure what changed along the way....but we no longer need thi…
…s funny business in Wings::ActiveFedoraConverter#apply_attributes_to_model in order for spec/wings/active_fedora_converter_spec.rb:365 to pass! 🎉 now lets hope it also passes in ci. 😩
Configuration menu - View commit details
-
Copy full SHA for 580d817 - Browse repository at this point
Copy the full SHA 580d817View commit details -
update Hyrax::Actors::BaseActor#save to pass the correct argument/par…
…ameter combo to #valkyrie_save, and therfore Persister#save
Configuration menu - View commit details
-
Copy full SHA for 04fac65 - Browse repository at this point
Copy the full SHA 04fac65View commit details -
remove the no longer necessary rubocop disable comment from active_fe…
…dora_converter.rb
Configuration menu - View commit details
-
Copy full SHA for b16bace - Browse repository at this point
Copy the full SHA b16baceView commit details -
revert the changes from 8970a44 and update the assertion to spec/serv…
…ices/hyrax/admin_set_create_service_spec.rb:294
Configuration menu - View commit details
-
Copy full SHA for f992e10 - Browse repository at this point
Copy the full SHA f992e10View commit details -
converting a valkyrie resource lease into an active fedora lease is r…
…idiculously tricky and I wish we did not have to.
Configuration menu - View commit details
-
Copy full SHA for 96f5719 - Browse repository at this point
Copy the full SHA 96f5719View commit details