Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IIIF manifests when the presenter model is a SolrDocument #6152

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

dlpierce
Copy link
Contributor

Summary

hydra_model is already a class, don't call class on it

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Manifests in koppie or Nurax PG include a sequence section with URLS for the IIIF endpoint.
  • or
  • The universal viewer displays the work's images.

Type of change (for release notes)

  • notes-valkyrie Valkyrie Progress

Detailed Description

Fix IIIF manifests when the presenter model is a SolrDocument. hydra_model already returns a class. Calling class on it breaks the Hyrax::Resource subclass determination causing the wrong code path to be used resulting in a manifest without any images.

@samvera/hyrax-code-reviewers

Fixes IIIF manifests when the presenter model is a SolrDocument. `hydra_model` already returns a class. Calling `class` on it breaks the Hyrax::Resource subclass determination.
@dlpierce dlpierce added the notes-valkyrie Release Notes: Valkyrie specific label Aug 15, 2023
@orangewolf
Copy link
Member

looks great

@dlpierce dlpierce merged commit d6bd494 into main Aug 15, 2023
@dlpierce dlpierce deleted the fix-valk-manifests branch August 15, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-valkyrie Release Notes: Valkyrie specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants