Fix IIIF manifests when the presenter model is a SolrDocument #6152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
hydra_model is already a class, don't call
class
on itGuidance for testing, such as acceptance criteria or new user interface behaviors:
Type of change (for release notes)
notes-valkyrie
Valkyrie ProgressDetailed Description
Fix IIIF manifests when the presenter model is a SolrDocument.
hydra_model
already returns a class. Callingclass
on it breaks the Hyrax::Resource subclass determination causing the wrong code path to be used resulting in a manifest without any images.@samvera/hyrax-code-reviewers