use Valkryie for all test setup in edit_permissions_service_spec #6172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
refactor-edit-perm-serv-spec
branch
from
ac0c9be
to
6a4d5a4
Compare
added 3 commits
August 23, 2023 15:30
this is a model heavy test, and yes, the setup is slow, but that's a code smell we shouldn't be hiding with convoluted test setup.
makes this test compatible with Valkyrie by refactoring out ActiveFedora based factories. the methodology i used here is to: - stand up dassie; - refactor for tidiness/to remove AF based mocks; - rewrite with Valkyrie factories; - test on dassie; - test on koppie
no-reply
force-pushed
the
refactor-edit-perm-serv-spec
branch
from
6a4d5a4
to
d6b370b
Compare
dlpierce
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes this test compatible with Valkyrie by refactoring out ActiveFedora based
factories.
the methodology i used here is to:
@samvera/hyrax-code-reviewers