Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[semver-major] drop support for Ruby before 3.2 #6183

Merged
merged 2 commits into from
Aug 25, 2023
Merged

[semver-major] drop support for Ruby before 3.2 #6183

merged 2 commits into from
Aug 25, 2023

Conversation

no-reply
Copy link
Contributor

drop support for older rubies and remove tests for them.

@samvera/hyrax-code-reviewers

@no-reply no-reply added the notes-major Release Notes: Potentially breaking changes label Aug 24, 2023
@no-reply no-reply force-pushed the ruby-3.2 branch 2 times, most recently from 77c11ce to 6013f89 Compare August 24, 2023 18:48
@no-reply
Copy link
Contributor Author

no-reply commented Aug 24, 2023 •
edited
Loading

@dlpierce this one really wants your approval, i think. it proposes:

  • dropping support for all rubies other than 3.2
  • dropping the practice of building with engine_cart as part of CI

[semver-major] drop support for Ruby before 3.2
bbba4dd 
drop support for older rubies that we're no longer testing.
dlpierce
dlpierce approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@dlpierce dlpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.7 served us well. 👋

@dlpierce dlpierce merged commit 94b1dd2 into main Aug 25, 2023
@dlpierce dlpierce deleted the ruby-3.2 branch August 25, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlpierce dlpierce dlpierce approved these changes

Assignees
No one assigned
Labels
notes-major Release Notes: Potentially breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@no-reply @dlpierce @dunn