Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dockerfile alpine and ruby versions #6205

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Conversation

mcritchlow
Copy link
Contributor

@mcritchlow mcritchlow commented Aug 24, 2023

Summary

  • Update Dockerfile to use Ruby 3.22, Alpine 3.18

This also affords dropping the manual installation of jemalloc, as in
Alpine 3.18 the desired version is in the package repository.

https://pkgs.alpinelinux.org/package/v3.18/main/x86_64/jemalloc

  • docker-compose: set solr ulimits

This fixes a known issues on some devices where the solr container can
take minutes to start.

Already applied on nurax[1].

  1. https://github.com/samvera-labs/nurax/blob/pg/docker-compose.yml#L113-L116

Guidance for testing, such as acceptance criteria or new user interface behaviors:

Type of change (for release notes)

notes-container

Changes proposed in this pull request:

  • Alpine version converted to ARG and updated to 3.18 as default in Dockerfile
  • Ruby version default updated to 3.22 in Dockerfile
  • jemalloc installed now using alpine package manager
  • ulimit set on solr container in docker compose files

@samvera/hyrax-code-reviewers

@mcritchlow mcritchlow changed the title Bump dockerfile alpine version Bump dockerfile alpine and ruby versions Aug 24, 2023
@mcritchlow mcritchlow added the notes-container Release Notes: Docker, Helm, etc label Aug 24, 2023
This also affords dropping the manual installation of jemalloc, as in
Alpine 3.18 the desired version is in the package repository.

https://pkgs.alpinelinux.org/package/v3.18/main/x86_64/jemalloc
This fixes a known issues on some devices where the solr container can
take minutes to start.

Already applied on nurax[1].

1. https://github.com/samvera-labs/nurax/blob/pg/docker-compose.yml#L113-L116
@no-reply no-reply force-pushed the bump-dockerfile-alpine-version branch from 1fa09ec to 1a1042e Compare August 24, 2023 15:59
Copy link
Contributor

@no-reply no-reply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic! thanks for taking the initiative!

@no-reply no-reply merged commit 65dda3b into main Aug 24, 2023
@no-reply no-reply deleted the bump-dockerfile-alpine-version branch August 24, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-container Release Notes: Docker, Helm, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants