disable WorkFormService specs in .koppie #6255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
added
notes-valkyrie
WorkFormService is replaced by `Hyrax::FormFactory` for valkyrie. `BatchUploadFormService` inherited it (and is used with valkyrie), but doesn't actually use the behavior. drop the class relationship to avoid confusion. right before a major release is a great time to drop behavior like this :)
dlpierce
force-pushed
the
wk-form-serv
branch
from
bb87785
to
a62e4e5
Compare
dlpierce
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorkFormService is replaced by
Hyrax::FormFactoryfor valkyrie.BatchUploadFormServiceinherited it (and is used with valkyrie), but doesn't actually use the behavior. drop the class relationship to avoid confusion. right before a major release is a great time to drop behavior like this :)@samvera/hyrax-code-reviewers