Don't force "Collection" model filter from the view #6273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
5522-my-collections-search
branch
from
0c1cfc6
to
9c73ed2
Compare
added 2 commits
August 30, 2023 19:50
the issue in #5522 is that search filters for collections aren't working correctly on `.koppie` (when collections have `model_name` other than `Collection`). the relevant controller specs were completely stubbed on all the related behavior. this unstubs them so there's a narrow test that fails related to the issue.
the search builders for the target controller already search effectively for the model class, and may have better strategies for doing so in the future. adding a filter here prevents applications from using Collection models not named "Collection".
no-reply
force-pushed
the
5522-my-collections-search
branch
from
9c73ed2
to
5ff2a04
Compare
mcritchlow
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes a Valkyrie-only bug where collections are filtered en-masse from the Collection listing because they are indexed from a model other than the AF
Collectionrefs #5522
Summary
the search builders for the target controller already search effectively for the
model class, and may have better strategies for doing so in the future. adding a
filter here prevents applications from using Collection models not named
"Collection".
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Changes proposed in this pull request:
@samvera/hyrax-code-reviewers