Generate terms and build permitted params for valkyrie ResourceBatchEditForm dynamically. #6289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsitu
force-pushed
the
batch-edit-terms
branch
from
a0e454e
to
5e3e95d
Compare
lsitu
force-pushed
the
batch-edit-terms
branch
from
5e3e95d
to
616e191
Compare
lsitu
force-pushed
the
batch-edit-terms
branch
2 times, most recently
from
26062de
to
332acab
Compare
|
@tpendragon @no-reply This is an improvement as a response to the review comment #6148 (comment) for valkyrie batch edit. |
tpendragon
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #6293, #5797 ; refs #6293, #5797
Summary
Dynamically generate terms and build permitted params for valkyrie batch edit.
For Reviewers
If there's work that needs to be done on this PR, it should get picked up by the Princeton team.
@samvera/hyrax-code-reviewers