Default sort order of notifications page #6327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
None, committing back a local override
Summary
Changes the default sort order on the notifications page to sorting in descending order by timestamp, so that newest notifications display first.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Visit the notifications page by clicking the notification counter at the top of the page. Observe that without this PR the notifications display oldest notifications first. With this PR, the new notifications are displayed first.
Type of change (for release notes)
notes-bugfix - default the notifications page to display newest entries first
Detailed Description
This was a local override in our repository that was requested so that users wouldn't have to page through all their old notifications to see recent activity. While updating overrides, I figured it would make sense to offer it back in case it was useful more broadly.
Changes proposed in this pull request:
Sets a default sort for datatables in the html of the notifications table.
@samvera/hyrax-code-reviewers