Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #6337
Summary
Hyrax permissions are broken on Fedora 6 due to the attribute
:mode
ofHyrax::Permission
not getting preserved properly through the older Valkyrie Fedora adapter.:mode
is passed to the Valkyrie Fedora adapter as aSymbol
, and versions of Valkyrie prior to3.1.1
do not handle preservingSymbol
values properly for Fedora.Guidance for testing, such as acceptance criteria or new user interface behaviors:
Type of change (for release notes)
notes-bugfix
Bug FixesDetailed Description
I submitted a PR to Valkyrie to convert
Symbol
values toString
when preserving them through the Fedora adapter. This ensure the:mode
attribute ofHyrax::Permission
, which is of typeValkyrie::Types::Coercible::Symbol
, is preserved correctly on Fedora. The latest version of Valkyrie, 3.1.1, includes changes in that PR.Changes proposed in this pull request:
@samvera/hyrax-code-reviewers