Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Valkyrie to 3.1.1 #6340

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

abelemlih
Copy link
Contributor

Fixes

Fixes #6337

Summary

Hyrax permissions are broken on Fedora 6 due to the attribute :mode of Hyrax::Permission not getting preserved properly through the older Valkyrie Fedora adapter. :mode is passed to the Valkyrie Fedora adapter as a Symbol, and versions of Valkyrie prior to 3.1.1 do not handle preserving Symbol values properly for Fedora.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Running locally with Valkyrie/Fedora, log in to dashboard as admin user
  • Create a new Generic Work
  • Add required metadata and a file
  • Select Public as Visibility and save
  • Work will save and visibility will be set to Private

Type of change (for release notes)

  • notes-bugfix Bug Fixes

Detailed Description

I submitted a PR to Valkyrie to convert Symbol values to String when preserving them through the Fedora adapter. This ensure the :mode attribute of Hyrax::Permission, which is of type Valkyrie::Types::Coercible::Symbol, is preserved correctly on Fedora. The latest version of Valkyrie, 3.1.1, includes changes in that PR.

Changes proposed in this pull request:

  • Upgrade Valkyrie to 3.1.1

@samvera/hyrax-code-reviewers

@abelemlih abelemlih requested a review from dlpierce October 5, 2023 21:30
@dlpierce dlpierce merged commit 94e3b4e into main Oct 5, 2023
@dlpierce dlpierce deleted the abel-6337-fix_fedora_hyrax_permissions branch October 5, 2023 21:48
@dlpierce dlpierce added the notes-minor Release Notes: Non-breaking features label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-minor Release Notes: Non-breaking features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Valkyrie/Fedora, work cannot be saved with Public visibility
2 participants