Collection and sidebar style fixes #6360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…il and title of works. Adjust sizing of action bar on collection page so that the buttons don't overlap the work table a somewhat lower resolutions.
…ll not stick of the sidebar area, and to center the icons
…d checkboxes when selecting all batch document checkboxes
dlpierce
approved these changes
Oct 12, 2023
|
Thank you for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Display issues with collection pages and the dashboard sidebar in hyrax 4 and 5.
Summary
A few minor style fixes for the collection pages (both in the dashboard and the public display), and the sidebar in the dashboard
Guidance for testing, such as acceptance criteria or new user interface behaviors:
View any collection with at least one work added to it. Do so in both the public and dashboard view.
Type of change (for release notes)
notes-minor
Detailed Description
On collection pages in hyrax 4-5, we got feedback about the following issues:
See this images for an example of the problems:
Additionally, when collapsing the sidebar menu using the "<" button, the text of the menu entries continue to be visible but what a white text color:
Changes proposed in this pull request:
This PR addresses the described issues with collection pages and the sidebar. The collection page spacing should look similar to the following (depending on the width of your window):
@samvera/hyrax-code-reviewers