Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix valkyrie resource json response #6372

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Fix valkyrie resource json response #6372

merged 4 commits into from
Oct 19, 2023

Conversation

dlpierce
Copy link
Member

Fixes

Fixes #6366

Summary

Fix valkyrie resource json response

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Adding .json to a work's show page url gives a json representation of the work
  • Other responses that depend on building a graph (.ttl .nt .jsonld) return a 501 not implemented status for valkyrie resources

Changes proposed in this pull request:

  • For the json response, use the work id to find_by
  • Don't attempt to respond to formats that depend on building a graph with active fedora
  • Move response formats to individual methods
  • Fix work_controller_behavior_spec for koppie

@samvera/hyrax-code-reviewers

@dlpierce dlpierce added the notes-valkyrie Release Notes: Valkyrie specific label Oct 19, 2023
@dlpierce dlpierce merged commit e4f7409 into main Oct 19, 2023
@dlpierce dlpierce deleted the work_show_json branch October 19, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwatson78 bwatson78 bwatson78 approved these changes

Assignees
No one assigned
Labels
notes-valkyrie Release Notes: Valkyrie specific
Projects
None yet
Milestone
No milestone
2 participants
@dlpierce @bwatson78