Turns off AF testing in koppie testing for nested_collections_search_builder_spec. #6409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpierce
approved these changes
Nov 2, 2023
dlpierce
deleted the
make_nested_collections_search_builder_spec_wings_aware
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes
spec/search_builders/hyrax/dashboard/nested_collections_search_builder_spec.rbfailures in koppie spec.Summary
Turns off AF testing in koppie testing for nested_collections_search_builder_spec.
Type of change (for release notes)
notes-valkyrieValkyrie ProgressDetailed Description
Avoids ActiveFedora-specific testing when running test suite in Koppie by checking
Hyrax.config.disable_wingsand only using Valkyrie objects if true.@samvera/hyrax-code-reviewers