Updates iiif_manifest_presenter_spec for Valkyrie. #6446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwatson78
commented
Nov 14, 2023
| FactoryBot.valkyrie_create(:hyrax_file_set, | ||
| files: [second_file_metadata], | ||
| visibility_setting: Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED) | ||
| end |
There was a problem hiding this comment.
Note: the above code is the only setup that doesn't automatically create FileSets with the mime_type of octet streams.
bwatson78
force-pushed
the
updates_iiif_manifest_presenter_spec
branch
2 times, most recently
from
605b79c
to
6374da0
Compare
|
I'm going to fix this up to not need the koppie switches. |
dlpierce
force-pushed
the
updates_iiif_manifest_presenter_spec
branch
from
6374da0
to
d5bf57b
Compare
no-reply
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes
spec/presenters/hyrax/iiif_manifest_presenter_spec.rbSummary
Updates iiif_manifest_presenter_spec for Valkyrie.
Type of change (for release notes)
notes-valkyrieValkyrie ProgressChanges proposed in this pull request:
@samvera/hyrax-code-reviewers