Makes spec/services/hyrax/file_set_fixity_check_service_spec.rb Dassie-only. #6459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't this code need to work for koppie? |
bwatson78
force-pushed
the
updates_file_set_fixity_check_service_spec
branch
from
373d152
to
73f19f7
Compare
|
@no-reply I attempted to convert the tested FileSet to a :hyrax_file_set, but was blocked by errors stating that I tried to do due diligence and track down whether there was a separate Valkyrie process to perform Fixity, but couldn't find one. Would you happen to know where the Fixity processing starts for Valkyrie FileSets? |
bwatson78
force-pushed
the
updates_file_set_fixity_check_service_spec
branch
3 times, most recently
from
bdc010a
to
ad6b7a4
Compare
dlpierce
reviewed
Dec 1, 2023
Co-authored-by: Daniel Pierce <dlpierce@indiana.edu>
bwatson78
force-pushed
the
updates_file_set_fixity_check_service_spec
branch
from
0d57624
to
e78c619
Compare
dlpierce
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes
spec/services/hyrax/file_set_fixity_check_service_spec.rb.Summary
Makes spec/services/hyrax/file_set_fixity_check_service_spec.rb Dassie-only.
Type of change (for release notes)
Add an appropriate
notes-*label to the PR (or indicate here) that classifies this change.notes-valkyrieValkyrie Progress@samvera/hyrax-code-reviewers