Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valkyrization: Fix failing tests in featured_work_list_spec.rb #6468

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Valkyrization: Fix failing tests in featured_work_list_spec.rb #6468

merged 1 commit into from
Nov 27, 2023

Conversation

abelemlih
Copy link
Contributor

@abelemlih abelemlih commented Nov 22, 2023 •
edited
Loading

Fixes

Fix failing tests in spec/models/featured_work_list_spec.rb for Koppie.

Type of change (for release notes)

  • notes-valkyrie Valkyrie Progress

Changes proposed in this pull request:

  • Change work creation to be Valkyrie compatible
  • Use the work deletion transaction to delete a work

@samvera/hyrax-code-reviewers

@abelemlih abelemlih added valkyrization notes-valkyrie Release Notes: Valkyrie specific labels Nov 22, 2023
@abelemlih abelemlih self-assigned this Nov 22, 2023
@abelemlih abelemlih changed the title Fix featured_work_list_spec.rb Valkyrization: Fix failing tests in featured_work_list_spec.rb Nov 22, 2023
@dlpierce dlpierce merged commit d4644a0 into main Nov 27, 2023
4 checks passed
@dlpierce dlpierce deleted the abel-fix_featured_work_list_spec branch November 27, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlpierce dlpierce dlpierce approved these changes

Assignees

@abelemlih abelemlih

Labels
notes-valkyrie Release Notes: Valkyrie specific valkyrization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abelemlih @dlpierce