Moves test that checks AF objects with Valkyrie Ids, then Valkyrizes it in original location. #6544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t in original location.
dlpierce
approved these changes
Dec 14, 2023
dlpierce
deleted the
adjusts_custom_queries_navigators_child_works_navigator_spec
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes
spec/services/hyrax/custom_queries/navigators/child_works_navigator_spec.rb.Summary
Moves test that checks AF objects with Valkyrie Ids, then Valkyrizes it in original location.
Type of change (for release notes)
notes-valkyrieValkyrie ProgressDetailed Description
Since
spec/services/hyrax/custom_queries/navigators/child_works_navigator_spec.rbtests whether ActiveFedora objects that are transformed via Wings still appear in this custom query, it holds relevance and should be maintained, which is why it's copied in its entirety tospec/wings/services/custom_queries/navigators/child_works_navigator_spec.rb.The original test suite stays after being Valkyrized.
@samvera/hyrax-code-reviewers