Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valkyrization: Mark work_query_service_spec.rb as ActiveFedora only #6599

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

abelemlih
Copy link
Contributor

Fixes

Mark spec/services/hyrax/work_query_service_spec.rb as ActiveFedora-only since Valkyrized applications rely on app/services/hyrax/work_resource_query_service.rb instead. Refer to the following in app/models/proxy_deposit_request.rb:

# line 10
self.work_query_service_class = Hyrax.config.use_valkyrie? ? Hyrax::WorkResourceQueryService : Hyrax::WorkQueryService

Type of change (for release notes)

  • notes-valkyrie Valkyrie Progress

Changes proposed in this pull request:

  • Mark spec/services/hyrax/work_query_service_spec.rb as ActiveFedora only

@samvera/hyrax-code-reviewers

@abelemlih abelemlih added valkyrization notes-valkyrie Release Notes: Valkyrie specific labels Jan 10, 2024
@abelemlih abelemlih self-assigned this Jan 10, 2024
@abelemlih abelemlih force-pushed the abel-fix_work_query_service_spec.rb branch from 168f288 to e14c522 Compare January 10, 2024 18:41
@dlpierce dlpierce merged commit 0715cfc into main Jan 11, 2024
4 checks passed
@dlpierce dlpierce deleted the abel-fix_work_query_service_spec.rb branch January 11, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-valkyrie Release Notes: Valkyrie specific valkyrization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants