Fix search results for works with matching fileset keywords #6645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes inclusion of FileSet and Hyrax::FileSet in catalog search subquery. Use of wildcard avoids dealing with escaping "::" and matching both "FileSet" and "Hyrax::FileSet"
dlpierce
added
notes-valkyrie
jeremyf
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes catalog controller spec in koppie and display of works where only the Hyrax::FileSet matches the query.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Detailed Description
The previous attempt to add
Hyrax::FileSetto the existing requirement of "FileSetby way of the!termsquery did not work properly, perhaps not filtering at all.Changes proposed in this pull request:
@samvera/hyrax-code-reviewers