Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Use configured class instead of hard-coded #6717

Merged
merged 2 commits into from
Mar 11, 2024
Merged

🐛 Use configured class instead of hard-coded #6717

merged 2 commits into from
Mar 11, 2024

Commits on Feb 23, 2024

  1. 🐛 Use configured class instead of hard-coded 

    The baseline configuration for the `Hyrax::PcdmMemberPresenterFactory`
allows for us to specify the `file_presenter_class` and the
`work_presenter_class`.  However, in the case of `presenter_for` we were
not leveraging that configurability.

This commit rectifies that behavior.

Tagging along with this commit is a minor performance improvement.
Namely, check a simple boolean before we begin checking elements that
might require additional queries and/or loading additional objects.
    @jeremyf
    jeremyf committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    c5db547 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-bug-in-configurability

    @jeremyf
    jeremyf authored Feb 23, 2024
    Configuration menu
    Copy the full SHA
    bd19068 View commit details
    Browse the repository at this point in the history