Allow removal of Location fields, and related QOL fixes #6720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terms now, and should correctly allow for values to be removed on new and existing works. Adds placeholder text to location inputs after the first one.
jeremyf
approved these changes
Mar 11, 2024
jeremyf
added a commit
that referenced
this pull request
Mar 20, 2024
* main: 🐛 Use configured class instead of hard-coded (#6717) Remove button should always appear next to location/controlled vocab terms now, and should correctly allow for values to be removed on new and existing works. Adds placeholder text to location inputs after the first one. (#6720) ♻️ Ensure setting permission template for work factories (#6723) Use compact, not flatten, in the model registry (#6737)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#6719
Summary
Fixes issue with the Location field (as described in 6719), that prevents removal of the first location field. Fixes a few other issues and gets the display a little more consistent.
Work was done by @davidcam-src
Guidance for testing, such as acceptance criteria or new user interface behaviors:
See the linked ticket. It's helpful to add and remove locations at the same time for both new and existing works, and then verifying the expected locations show up on the work.
To test in Dassie, you'll need to update the
.dassie/.envfile to add aGEONAMES_USERNAME=entry with a valid geonames username.Type of change (for release notes)
notes-bugfix
Detailed Description
Resolves an additional issue when creating a new work, where adding and then removing a location will result in the removed location appearing on the created work.
Adds in placeholder text for inputs after the first one (with the same placeholder text as the first input)
Some additional complications arose when deleting entries on existing works due to index collisions between delete and newly added entries.
Changes proposed in this pull request:
@samvera/hyrax-code-reviewers