Application generation fixes #6728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpierce
added
notes-bugfix
jeremyf
approved these changes
Mar 1, 2024
jeremyf
added a commit
that referenced
this pull request
Mar 1, 2024
* main: Prep 5.0.0 Application generation fixes (#6728) New query strategy to join FileSet solr documents The helm chart says it evaluates extraEnvVars but it was not actually doing so (#6718) Add tests for dashboard/CatalogController#index which fail when not logged in prior to this update. Remove authentication exception for the index endpoint from this catalog controller, since it results in errors. Removing it here causes the controller to use the check from its parent class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few last minute fixes for application generation and documentation