move file related listeners to their own space #6743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
commented
Mar 26, 2024
these listener methods don't have to do with `FileMetadata`, so they should be reorganized out into their own class. this makes it easier for downstream apps to override behaviors that are only related to files.
dlpierce
approved these changes
Mar 28, 2024
jeremyf
added a commit
that referenced
this pull request
Apr 2, 2024
* main: prepare release 5.0.1 fix blueimp file upload progress bars Pin sprockets to fix feature specs (#6762) move file related listeners to their own space (#6743) Fix “::Collection” definition with autoloading use the `Hyrax::FileSetFileService` to determine "primary file" make `default_workflow_spec.rb` order independent Fix typo for the raise statement chart: add support for startupProbe use `find_files(file_set: file_set)` in various specs avoid n+1 query on file_metadata delete ♻️ Liberating Factories Prevent current_ability from failing when SingleUseLink doesn't exist, and make current user available via current_ability Add failing tests for current_user in single use links viewer controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these listener methods don't have to do with
FileMetadata, so they should be reorganized out into their own class. this makes it easier for downstream apps to override behaviors that are only related to files.@samvera/hyrax-code-reviewers