-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 6755 #6896
Merged
Merged
Issue 6755 #6896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 17 files ±0 17 suites ±0 2h 19m 2s ⏱️ + 3m 2s Results for commit 1aca567. ± Comparison against base commit b02cd98. This pull request removes 274 and adds 274 tests. Note that renamed tests count towards both.
|
kirkkwang
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Adds override for blue background color used by Bootstrap to use a blue with color contrast greater than 7:1. This passes WCAG 2.2 Level AAA requirements.
Fixes #6755
Summary
Based on Bootstrap 4.6.2 variable styles in use with current Hyrax, there are known accessibility problems with some color contrasts. Overriding the color assigned to this blue variable makes sure anything using that color (primary class, at least) will contrast enough for accessibility.
Type of change (for release notes)
notes-minor
Accessibility fix@samvera/hyrax-code-reviewers