Fix location indexing

[laritakr]

Fixes

Location indexer now includes the term needed for location faceting.

Summary

Valkyrie resources were not indexing term based_near_label_sim which is needed for the location facet, so they were not appearing in the facet.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

A new work using based_near location will now appear in the facet on the catalog page.

Type of change (for release notes)

• notes-bugfix Bug Fixes

Changes proposed in this pull request:

• Fix location facet indexing by indexing the needed term
• Add a safeguard that we don't attempt to call the location service on a blank term, as this crashes the service.

@samvera/hyrax-code-reviewers

[github-actions]

Test Results

    17 files  ±0      17 suites  ±0   2h 16m 38s ⏱️ -23s
 6 713 tests  - 1   6 416 ✅ ±0  297 💤 ±0  0 ❌  - 1 
13 198 runs  ±0  12 802 ✅ +1  396 💤 ±0  0 ❌  - 1 

Results for commit a8db0ad. ± Comparison against base commit ce352d3.

This pull request removes 274 and adds 273 tests. Note that renamed tests count towards both.

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f4c91329b20>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f5a5d316190>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f4c913234a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f5a5ccbe108>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 5faf76b0-f1c3-463c-a810-c949ff82ca10
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 0616b72f-4864-4106-917c-14814c2063ae
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 77cc5cf9-070d-4e00-826a-6ff3118aaf79
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: ae5e62bb-04a5-4e2e-be24-aaee463c59a8
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: e189b8bb-7af6-442a-ad06-5c29a205ad2a
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 5926475f-4e52-4dfe-b636-b80a92c3ba3d
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f330d0aa3d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fd60ebe9ec0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f330f3b9d88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fd6173494d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 34b8b41a-908a-44fb-b081-4a40caa6e7ea
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 3f56a849-f484-4c65-87e9-9ffb84bb5cea
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: e53c5f19-6d3d-4cb8-88fe-b156a875217b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 7b7211db-d2ba-4c0e-aa94-7e0f3dd6c934
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 47e10c2f-2d24-41ad-ab5c-908489875963
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 26d545c4-7f98-4ae3-a1b6-4f199169cf69
…

♻️ This comment has been updated with latest results.

[randalldfloyd]

+1 Good catch, thanks!