Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call to_rdf_representation in #collections? #6937

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Oct 29, 2024

When we upgraded Hyku's hyrax, two specs were failing for collection types.

Ultimately it's because our has_model_ssim for a CollectionResource is Collection. When Collections had collection types the search query still returned 0. Calling #to_rdf_representation resolves this issue, and is how the resource indexer indexes the has_model_ property.

Failing Hyku Specs:

BEFORE

  • rspec ./spec/features/collection_type_spec.rb:461 # collection_type delete collection type when collections exist of this type shows unable to delete dialog and forwards to All Collections with filter applied
  • rspec ./spec/features/collection_type_spec.rb:386 # collection_type edit collection type when collections exist of this type all settings are disabled

AFTER

$ bundle exec rspec ./spec/features/collection_type_spec.rb =>

image

Related PR:

When we upgraded Hyku's hyrax, two specs were failing in the specs for collection type.

Ultimately it's because our has_model_ssim for a CollectionResource is Collection. When Collections had collection types the search query still returns 0. Calling #to_rdf_representation resolves this issue.

# Failing Specs:

- [x] rspec ./spec/features/collection_type_spec.rb:461 # collection_type delete collection type when collections exist of this type shows unable to delete dialog and forwards to All Collections with filter applied
- [x] rspec ./spec/features/collection_type_spec.rb:386 # collection_type edit collection type when collections exist of this type all settings are disabled

# Related PR:
- e11d5d0#diff-72960bb29a2ce3ad9714ae0441c3a15def11b7ff2af54e47bc5d8b846bbc1d16
@ShanaLMoore ShanaLMoore changed the title Update collection_type.rb call to_rdf_representation in #collections? Oct 29, 2024
@ShanaLMoore ShanaLMoore added the notes-minor Release Notes: Non-breaking features label Oct 29, 2024
Copy link

github-actions bot commented Oct 29, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 16m 17s ⏱️ -37s
 6 717 tests ±0   6 420 ✅ ±0  297 💤 ±0  0 ❌ ±0 
13 204 runs  ±0  12 808 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit 4e6035a. ± Comparison against base commit d16baff.

This pull request removes 267 and adds 267 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fabb2269890>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fb6a031d720>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fabb2261550>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fb688487308>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 08dc597c-60a0-4f21-b4b2-a324bee27b57
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: c2aff474-1206-4d3d-a0e0-229305dc01dd
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: c8ea0f54-e0c6-453e-bbb3-db4fb8f76fee
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: f416a196-8bce-4d14-ba3e-e0d13ad4135e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: b515b113-e0fc-4147-a816-87822a6e3766
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: e8638124-2267-4320-ac74-9416bc11c601
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f3404569d90>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fc8609e7598>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f3404564110>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fc8786e0288>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 8dfef79c-b4d3-4073-86eb-508aa3874c24
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 3f724047-dda3-4b36-bebd-74ecd0671dc2
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 38c326d8-bd69-4f10-b78f-e76eca29fe23
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: a019b421-ce14-4023-a35c-3e69d4b3a718
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: fa148d6c-ced1-4f88-bca1-834c1c6ae4d6
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: aeeecbbb-78a0-4fbb-885a-552c6846d1cf
…

♻️ This comment has been updated with latest results.

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@ShanaLMoore ShanaLMoore merged commit a8ae953 into main Oct 30, 2024
22 checks passed
@ShanaLMoore ShanaLMoore deleted the collection-type-fix branch October 30, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-minor Release Notes: Non-breaking features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants