-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
call to_rdf_representation in #collections? #6937
Conversation
When we upgraded Hyku's hyrax, two specs were failing in the specs for collection type. Ultimately it's because our has_model_ssim for a CollectionResource is Collection. When Collections had collection types the search query still returns 0. Calling #to_rdf_representation resolves this issue. # Failing Specs: - [x] rspec ./spec/features/collection_type_spec.rb:461 # collection_type delete collection type when collections exist of this type shows unable to delete dialog and forwards to All Collections with filter applied - [x] rspec ./spec/features/collection_type_spec.rb:386 # collection_type edit collection type when collections exist of this type all settings are disabled # Related PR: - e11d5d0#diff-72960bb29a2ce3ad9714ae0441c3a15def11b7ff2af54e47bc5d8b846bbc1d16
Test Results 17 files ±0 17 suites ±0 2h 16m 17s ⏱️ -37s Results for commit 4e6035a. ± Comparison against base commit d16baff. This pull request removes 267 and adds 267 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! 👍
When we upgraded Hyku's hyrax, two specs were failing for collection types.
Ultimately it's because our has_model_ssim for a CollectionResource is Collection. When Collections had collection types the search query still returned 0. Calling #to_rdf_representation resolves this issue, and is how the resource indexer indexes the has_model_ property.
Failing Hyku Specs:
BEFORE
AFTER
$ bundle exec rspec ./spec/features/collection_type_spec.rb
=>Related PR: