Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added presentation role to edit collection type list items #6940

Merged

Conversation

rkuehn-uofl
Copy link
Contributor

Fixes

Fixes #6799

Summary

Corrects accessibility issue with list items in edit collection type form.
Adds role="presentation" to <li class="nav-item"> elements to prevent ARIA semantics from unnecessarily being exposed.

Type of change (for release notes)

  • notes-minor Adds presentation role to list items for accessibility

@samvera/hyrax-code-reviewers

@rkuehn-uofl rkuehn-uofl linked an issue Oct 30, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 30, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 18m 8s ⏱️ + 2m 27s
 6 717 tests ±0   6 420 ✅ ±0  297 💤 ±0  0 ❌ ±0 
13 204 runs  ±0  12 808 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit 18cfa22. ± Comparison against base commit 5e7f26d.

This pull request removes 264 and adds 264 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f96eabc9110>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fa9b3fb0018>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f96f0660150>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fa9b4144398>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: bb9ee608-3e7d-4f05-a47a-cb098b762eb6
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 2d064183-5c8b-4bb0-8d25-b2cff57cfdfc
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: a4c57463-f096-4574-a69b-8cc8ecc77b7c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: ac9896b9-f8d4-4171-811d-1a07a5396600
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 51f688be-963c-45ca-b29c-91632b30077d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: fa27940d-6559-464d-891e-5dfabb7eb229
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007efee8c77958>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f42d3b26188>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007efee8c508d0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f42d31649d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 106cbceb-8be8-428a-96f4-8dbcc5243295
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: d650948d-6ed1-479f-9851-dc012b6d9aec
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 6a9feb64-0d81-4b4f-878b-2a0918550f10
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: f6054337-08ca-455e-8d60-530b9572ce4b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 57f2e95e-9937-40b1-a2d6-567a87ddf40b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 82ba468b-2019-471e-b697-b8588a6e3576
…

♻️ This comment has been updated with latest results.

@randalldfloyd randalldfloyd force-pushed the 6799-tabs-on-edit-collection-page-missing-role-context branch from 91f89da to 18cfa22 Compare November 1, 2024 13:51
@randalldfloyd randalldfloyd merged commit 139c881 into main Nov 1, 2024
22 checks passed
@randalldfloyd randalldfloyd deleted the 6799-tabs-on-edit-collection-page-missing-role-context branch November 1, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs on edit collection page missing role context
2 participants