-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reindex fileset after file lazy migration #6954
Open
laritakr
wants to merge
6
commits into
main
Choose a base branch
from
reindex-fileset-after-file-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laritakr
changed the title
Reindex fileset after file migration
Reindex fileset after file lazy migration
Nov 1, 2024
orangewolf
previously approved these changes
Nov 1, 2024
Test Results 17 files ±0 17 suites ±0 2h 16m 3s ⏱️ +35s Results for commit e4e9244. ± Comparison against base commit 082fc72. This pull request removes 266 and adds 266 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Passed locally but not on github... trying again
laritakr
force-pushed
the
reindex-fileset-after-file-migration
branch
from
November 1, 2024 19:21
78bced8
to
7bfd25d
Compare
laritakr
force-pushed
the
reindex-fileset-after-file-migration
branch
from
November 1, 2024 21:04
1495543
to
e4e9244
Compare
ShanaLMoore
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Lazy migration on fileset did not index characterization.
Failing spec before changes
Summary
Reindexes the fileset after the files are migrated.
Type of change (for release notes)
Bug fix
@samvera/hyrax-code-reviewers