Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reindex fileset after file lazy migration #6954

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

laritakr
Copy link
Contributor

@laritakr laritakr commented Nov 1, 2024

Fixes

Lazy migration on fileset did not index characterization.

Failing spec before changes

Screenshot 2024-11-01 at 11 47 34 AM

Summary

Reindexes the fileset after the files are migrated.

Type of change (for release notes)

Bug fix

@samvera/hyrax-code-reviewers

@laritakr laritakr added the notes-bugfix Release Notes: Fixed a bug label Nov 1, 2024
@laritakr laritakr changed the title Reindex fileset after file migration Reindex fileset after file lazy migration Nov 1, 2024
orangewolf
orangewolf previously approved these changes Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 16m 3s ⏱️ +35s
 6 729 tests ±0   6 432 ✅ ±0  297 💤 ±0  0 ❌ ±0 
13 229 runs  ±0  12 833 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit e4e9244. ± Comparison against base commit 082fc72.

This pull request removes 266 and adds 266 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f766f315b40>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fbdfa611060>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f766e7e4758>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fbdf5324b18>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: d355db71-0c2d-4b94-9e36-2f91242205fd
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 162634c4-d50b-4038-afb6-c1c0a0b144d7
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 5c6c789a-8e5d-4054-8fd8-e0dca6a38374
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: a8047180-96cf-4f9f-9ffb-b8ceccca218b
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 1c86e7be-2a7e-4bc6-94d2-f7fe06fb04bd
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 732c7352-666d-4599-bbc0-2f8da67cdc40
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fa6c4214608>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fd2f3e12d00>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fa6c37ebb90>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fd2f382dc00>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 61d62fcb-dc28-45fa-be62-bc9a8cfb85a1
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: d0a49405-ae59-40dd-8d80-5b7553e59e62
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 8e254811-6a2a-4c99-93fe-0489029a5905
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: bec46c31-e770-413f-b107-ea2128c80c32
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 24a483f0-97ca-43b1-aafb-c4aa54094150
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 0c1efe98-05f3-42bf-b781-435f9b090a27
…

♻️ This comment has been updated with latest results.

Passed locally but not on github... trying again
@laritakr laritakr force-pushed the reindex-fileset-after-file-migration branch from 1495543 to e4e9244 Compare November 1, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants