Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Type Facet for Valkyrie Resources #6968

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

orangewolf
Copy link
Member

Screenshot 2024-11-07 at 20 58 25

the side bar type is missing once AF records are reindexed.

Copy link

github-actions bot commented Nov 8, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 19m 54s ⏱️ + 3m 16s
 6 729 tests +1   6 432 ✅ +1  297 💤 ±0  0 ❌ ±0 
13 229 runs  ±0  12 833 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit 2d367f0. ± Comparison against base commit 83413b6.

This pull request removes 273 and adds 274 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f7722f212c8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fcf08726698>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f7722f26f48>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fcf0a719ec8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 058378f3-5bb8-48f4-9196-8db2b80f8090
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 2402ae0e-2d3b-46a4-9965-b3376bf90eeb
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: a5550cc8-c904-4559-a9eb-7f1c1d634077
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 1d3e9e45-7d81-4b06-81b5-1b206e11f71f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 7ee4ec34-1d62-4fb9-bd84-b2746c7bf553
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: a6f11e80-2499-4965-985a-aa952472a680
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f02f0dee9d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fc7fd414610>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f02f0de53d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fc7f7d1aa08>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 88289897-67b9-40d2-a560-755612dff2d3
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 97b67666-0076-4e92-8114-1a161b0a87b1
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: e37ed2e7-369c-45f6-922c-a5f710886dff
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 7d0abdf0-0baf-4c61-beb7-597cb5ab809e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 3aad0f71-86b7-4637-800b-8096c57c0747
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: c9918d09-3955-4b63-bb2b-8b1d0b9ad3e2
…

♻️ This comment has been updated with latest results.

@ShanaLMoore ShanaLMoore self-requested a review November 8, 2024 15:20
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Nov 8, 2024

I originally approved this without realizing there were pipeline failures. I'll try to resolve them.

@ShanaLMoore ShanaLMoore merged commit faae072 into main Nov 8, 2024
23 checks passed
@ShanaLMoore ShanaLMoore deleted the restore_human_readable_type_facet branch November 8, 2024 17:02
ShanaLMoore added a commit to samvera/hyku that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants