Adding Ruby 2.7.z and Rails 6.y.z releases to the CircleCI build configuration #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't look like circleCI is aware of this project |
jrgriffiniii
force-pushed
the
issues-43-jrgriffiniii-ruby-2.7
branch
from
d56249e
to
17648f7
Compare
|
I don't think this gem actually depends on rails (only activesupport). This is probably why the rails6/ruby2.4 build passed when it shouldn't have since it doesn't look like it was even pulling in rails in the bundle install. The circleci config could probably be really cleaned up by not taking the rails version into account and only having jobs for the 4 different ruby versions being tested. |
cjcolvar
approved these changes
Jan 21, 2020
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #43 and #44